Closed
Bug 648307
Opened 13 years ago
Closed 13 years ago
Create a mobile Tp pageset with real mobile pages
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mfinkle, Assigned: jmaher)
References
Details
(Whiteboard: [mobile_unittests])
Attachments
(4 files, 7 obsolete files)
3.68 KB,
patch
|
mozilla
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
2.59 KB,
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
25.70 KB,
patch
|
bear
:
review+
mozilla
:
checked-in+
|
Details | Diff | Splinter Review |
959 bytes,
patch
|
anodelman
:
review+
|
Details | Diff | Splinter Review |
I thought I filed this bug already, but can't find it. We reduced the size of the Tp pageset for mobile so we can stop OOM'ing during the tests. However, the pageset is 100% desktop webpages. We need a pageset with mostly mobile pages for testing the mobile browser. I have a pageset I have been using for Zippity that seems to work well. I'll post it.
Reporter | ||
Comment 1•13 years ago
|
||
bug 629503 reduced the Tp4 manifest size, but we need a whole new pageset
Assignee | ||
Comment 2•13 years ago
|
||
using the mobile only pages provided by mfinkle from the zippity tests and tools, I am able to run 22 mobile pages to completion in a tp4 style test a few times with no problems. On the same machine I could not run tp4 with >4 pages. I have a mobile_tp4.zip at http://people.mozilla.org/~jmaher/mobile_tp4.zip. This needs to be downloaded to the {talos}/page_load_test/ directory and unzipped there so you have: {talos}/page_load_test/mobile_tp4/{m.domain.com/...}
Assignee: nobody → jmaher
Attachment #524621 -
Flags: review?(aki)
Attachment #524621 -
Flags: feedback?(mark.finkle)
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•13 years ago
|
Whiteboard: [mobile_unittests]
Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 524621 [details] [diff] [review] update mobile talos tp4 to use mobile only pages (1.0) Yep, these are the pages I thought we were using. Sorry I dropped the ball getting us switched over to use the mobile-ish pageset. Thanks Joel
Attachment #524621 -
Flags: feedback?(mark.finkle) → feedback+
Comment 5•13 years ago
|
||
Comment on attachment 524621 [details] [diff] [review] update mobile talos tp4 to use mobile only pages (1.0) This cannot land until we have the appropriate factory changes, or all mobile tp4 runs will burn.
Attachment #524621 -
Flags: review?(aki) → review+
Assignee | ||
Comment 6•13 years ago
|
||
is that something I can help write? Otherwise, let me know when I can check this in.
Comment 7•13 years ago
|
||
I've pushed the mobile_tp4 pageset to bm-remote-talos-webhost-01 through 03, so the tegras should be good. I still need to write a patch for the n900s.
Comment 8•13 years ago
|
||
Attachment #525529 -
Flags: review?(jhford)
Comment 9•13 years ago
|
||
Comment on attachment 525529 [details] [diff] [review] mobile_tp4 n900 configs looks good. At some point we should delete the n810 stuff altogether as there is 0 chance of using it again.
Attachment #525529 -
Flags: review?(jhford) → review+
Comment 10•13 years ago
|
||
Tested on smm. Verified that the n900 downloaded+extracted+softlinked the tarball correctly. Verified that I could get to various pages in the mobile_tp4 manifest in my desktop browser if I s,localhost,n900-070, (The actual test run hung b/c it was using the un-patched mobile_tp4.manifest, so was looking for the tp4/ pageset; I think this level of testing should be acceptable.)
Attachment #525531 -
Flags: review?(jhford)
Comment 11•13 years ago
|
||
Comment on attachment 525531 [details] [diff] [review] mobile_tp4 n900 buildbotcustom sounds good and should be easy to backout if needed.
Attachment #525531 -
Flags: review?(jhford) → review+
Comment 12•13 years ago
|
||
Sweet. Joel: we're now ready to land; we just need to coordinate landing the patches at approximately the same time.
Comment 13•13 years ago
|
||
Comment on attachment 525531 [details] [diff] [review] mobile_tp4 n900 buildbotcustom http://hg.mozilla.org/build/buildbotcustom/rev/fb32670bde57
Attachment #525531 -
Flags: checked-in+
Comment 14•13 years ago
|
||
Comment on attachment 525529 [details] [diff] [review] mobile_tp4 n900 configs http://hg.mozilla.org/build/buildbot-configs/rev/48bfd4f1471b
Attachment #525529 -
Flags: checked-in+
Comment 15•13 years ago
|
||
Comment on attachment 524621 [details] [diff] [review] update mobile talos tp4 to use mobile only pages (1.0) http://hg.mozilla.org/build/talos/rev/be849ccbd6f3 Checked in with a horked -u (oops) but without the trailing newline, which may or may not have caused issues.
Attachment #524621 -
Flags: checked-in+
Assignee | ||
Comment 16•13 years ago
|
||
http://hg.mozilla.org/build/talos/pushloghtml?changeset=be849ccbd6f3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 17•13 years ago
|
||
Comment on attachment 524621 [details] [diff] [review] update mobile talos tp4 to use mobile only pages (1.0) backed out: http://hg.mozilla.org/build/talos/rev/683754ee01cc
Attachment #524621 -
Flags: checked-in+
Comment 18•13 years ago
|
||
Comment on attachment 525531 [details] [diff] [review] mobile_tp4 n900 buildbotcustom http://hg.mozilla.org/build/buildbotcustom/rev/84dd2e06593b
Attachment #525531 -
Flags: checked-in+
Comment 19•13 years ago
|
||
Comment on attachment 525529 [details] [diff] [review] mobile_tp4 n900 configs http://hg.mozilla.org/build/buildbot-configs/rev/0271461cc9e2
Attachment #525529 -
Flags: checked-in+
Assignee | ||
Comment 20•13 years ago
|
||
add all the pages from tp4 mobile pageset to the graph server. as a side note, I noticed a duplicate entry in data.sql while testing this: insert into machines values (NULL,1,0,"1.83","qm-pxp-try01",1,unix_timestamp());
Attachment #525760 -
Flags: review?(anodelman)
Comment 21•13 years ago
|
||
Comment on attachment 525760 [details] [diff] [review] graph server sql update for tp4m (1.0) +insert into tests values (NULL,"tp4m_nochrome", "Tp4 Mobile",0,1,14); Is this a nochrome test? If it is then the 'pretty name' should indicate it, if not then it shouldn't be called tp4m_nochrome.
Attachment #525760 -
Flags: review?(anodelman) → review-
Assignee | ||
Comment 22•13 years ago
|
||
updated to use tp4m instead of tp4.
Attachment #524621 -
Attachment is obsolete: true
Attachment #525769 -
Flags: review?(aki)
Reporter | ||
Comment 23•13 years ago
|
||
There will be chrome and nochrome versions, so I guess the pretty name should be fixed
Assignee | ||
Comment 24•13 years ago
|
||
updated with nochrome in the description as well.
Attachment #525760 -
Attachment is obsolete: true
Attachment #525770 -
Flags: review?(anodelman)
Updated•13 years ago
|
Attachment #525770 -
Flags: review?(anodelman) → review+
Assignee | ||
Comment 25•13 years ago
|
||
landed the graphs sql: http://hg.mozilla.org/graphs/pushloghtml?changeset=4864ec676914
Comment 26•13 years ago
|
||
Comment on attachment 525769 [details] [diff] [review] update mobile talos tp4 to use mobile only pages (2.0) Could you remove the last empty line in the manifest? I don't know if it'll cause issues, but it would make me feel better.
Attachment #525769 -
Flags: review?(aki) → review+
Comment 27•13 years ago
|
||
Comment 29•13 years ago
|
||
Attachment #525529 -
Attachment is obsolete: true
Comment 30•13 years ago
|
||
Comment on attachment 525883 [details] [diff] [review] jhford is gonna hate me This is broken on staging. I'm leaning towards landing tp4m for the tegras, and still running tp4 on the n900s til we get time to look at it.
Attachment #525883 -
Attachment is obsolete: true
Updated•13 years ago
|
Attachment #525885 -
Attachment is obsolete: true
Comment 31•13 years ago
|
||
From staging: RETURN:send failed, graph server says: RETURN:No test_name called 'tp4m_shutdown' can be found RETURN: File "/var/www/html/graphs2/server/pyfomatic/collect.py", line 264, in handleRequest RETURN: metadata = MetaDataFromTalos(databaseCursor, databaseModule, inputStream) RETURN: File "/var/www/html/graphs2/server/pyfomatic/collect.py", line 59, in __init__ RETURN: self.doDatabaseThings(databaseCursor) RETURN: File "/var/www/html/graphs2/server/pyfomatic/collect.py", line 102, in doDatabaseThings RETURN: raise DatabaseException("No test_name called '%s' can be found" % self.test_name) RETURN: RETURN:
Comment 32•13 years ago
|
||
Other than ^^ I think we're good. Let's aim for landing and reconfiging Tues morning; should be easy to add tp4m_shutdown to graphs sql (I think).
Comment 33•13 years ago
|
||
Attachment #525843 -
Attachment is obsolete: true
Attachment #526445 -
Flags: review?(bear)
Updated•13 years ago
|
Attachment #526445 -
Flags: review?(bear) → review+
Comment 34•13 years ago
|
||
tp4 is hidden on both mozilla-aurora and Mobile, so you'll need to use &noignore=1 on tbpl to see the effect of this landing.
Comment 35•13 years ago
|
||
This will create a new column for Tp4 Mobile (and remove the perma-orange tp4 for Android Tegra), so that will show up by default. Also, I'm going to land the non-n900 portions of attachment 526445 [details] [diff] [review].
Assignee | ||
Comment 36•13 years ago
|
||
Attachment #526716 -
Flags: review?(anodelman)
Assignee | ||
Comment 37•13 years ago
|
||
bear, we might want to update your patch to include: tp4m_shutdown tp4m_shutdown_nochrome
Comment 38•13 years ago
|
||
(In reply to comment #37) > bear, we might want to update your patch to include: > tp4m_shutdown > tp4m_shutdown_nochrome Not sure what patch this is referring to? tp4m_shutdown[_nochrome] gets run automatically when tp4m[_nochrome] runs, so if you're referring to attachment 526445 [details] [diff] [review] (sans n900 bits), that should still be good.
Assignee | ||
Comment 39•13 years ago
|
||
thanks aki, I just want to make sure all of the buildbot related patches for tp4m will with with shutdown.
Comment 40•13 years ago
|
||
Comment on attachment 526716 [details] [diff] [review] add in tp4m_shutdown sql to graph server (1.0) The shutdown tests do not require a pageset id. You can compare to the existing entries for tp4.
Attachment #526716 -
Flags: review?(anodelman) → review-
Comment 41•13 years ago
|
||
Comment on attachment 526716 [details] [diff] [review] add in tp4m_shutdown sql to graph server (1.0) I was incorrect about the pageset_id not being identified with the standard tp4 test. r+. Sorry for the confusion.
Attachment #526716 -
Flags: review- → review+
Assignee | ||
Comment 42•13 years ago
|
||
landed tp4m_shutdown on graphs repo: http://hg.mozilla.org/graphs/pushloghtml?changeset=df1845fcd5c0
Comment 43•13 years ago
|
||
Comment on attachment 526445 [details] [diff] [review] android tp4m configs, tested+unbitrotted Landed the Android Tegra portions: http://hg.mozilla.org/build/buildbot-configs/rev/4e43bbaa4927
Attachment #526445 -
Flags: checked-in+
Comment 44•13 years ago
|
||
Comment on attachment 525769 [details] [diff] [review] update mobile talos tp4 to use mobile only pages (2.0) Landed the Android Tegra portions (not mobile.config): http://hg.mozilla.org/build/talos/rev/43d49cf3ce13 When John Ford reconfigs tomorrow, we (Bear or I) need to update foopy*:/builds/talos-data/talos/ to get this change. There may be some burning if we time this poorly, but since we're currently hidden and perma-orange, the damage should be minimal.
Attachment #525769 -
Flags: checked-in+
Comment 45•13 years ago
|
||
On the Mobile tinderbox page; both tp4m and tp4m_nochrome have gone green at least once.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•